test(bigquery): warm up client in beforeClass to stabilize testFastSQLQueryMultiPage#13417
Open
jinseopkim0 wants to merge 1 commit into
Open
test(bigquery): warm up client in beforeClass to stabilize testFastSQLQueryMultiPage#13417jinseopkim0 wants to merge 1 commit into
jinseopkim0 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the integration test testFastSQLQueryMultiPage in ITBigQueryTest.java to use a generated array query instead of querying a large table, and fixes a bug where the updated configuration builder was not assigned back to the config variable. The reviewer suggested extracting the repeated assertions for the query results into a helper lambda to improve code maintainability and readability.
jinseopkim0
force-pushed
the
fix-fast-sql-query-b467064659
branch
5 times, most recently
from
5f857ec to
05692c2
Compare
jinseopkim0
force-pushed
the
fix-fast-sql-query-b467064659
branch
from
05692c2 to
58704d5
Compare
…LQueryMultiPage b/467064659
jinseopkim0
force-pushed
the
fix-fast-sql-query-b467064659
branch
from
8cf5c00 to
922ad35
Compare
jinseopkim0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/467064659